Remove Internet Explorer from test framework #8264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
added
compatibility
|
Maybe the right place to remove IE from karma.conf.js |
I think we should remove both, since it does not make sense to keep either around. Let me add a commit. |
jonkoops
changed the title
Closed
6 tasks
jonkoops
force-pushed
the
drop-ie-ci
branch
from
5598fc7 to
2db16ca
Compare
|
@mourner @IvanSanchez @Falke-Design @Malvoz this one is ready to be reviewed, would prevent a lot of random test failures so I'd like to merge this. |
Falke-Design
approved these changes
Sep 22, 2022
mourner
approved these changes
Sep 22, 2022
4 tasks
MaxEl-W
pushed a commit
to argustelecom/Leaflet
that referenced
this pull request
Jan 24, 2023
* Remove Internet Explorer from CI * Remove Internet Explorer from Karma config (cherry picked from commit e4c8f64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've decided to drop support for Internet Explorer (#6136) in v2 it makes sense to remove it from our test framework.