Fix scrolling in docs #7982
Merged
Fix scrolling in docs #7982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is a good way. |
|
Looks really good! Can this Leaflet/docs/docs/css/main.css Line 498 in 28d8ed5 that was introduces in #7703 be removed now? It seems to cause the following on mobile:
Edit: The black border disappears if that |
Malvoz
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
LGTM. Let's not block on #7982 (comment). Mobile has other issues (sticky headings not showing at all), they can be discussed separately.
|
No removing But it works with adding |
Malvoz
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling to the anchor is now be done manually instead of the browser internal function.
Fixes #7971
Closes #7972
Chromium browsers have a weird sideeffect. If we scroll to the same anchor in chromium browsers again, the scroll position has changed and the height of the sticky anchor was subtracted from the total scroll height / scroll position
@Malvoz, @NICEXAI, @avioli please check Demo