-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playsInline
attribute on the video element
#7928
Conversation
re #7364 (comment):
I think this should be good to merge. Without With |
We should setup a demo, so that we can easy share a link to check if it works. (I will share the dist js as a link in the next days). |
src/layer/VideoOverlay.js
Outdated
@@ -78,6 +78,7 @@ export var VideoOverlay = ImageOverlay.extend({ | |||
vid.autoplay = !!this.options.autoplay; | |||
vid.loop = !!this.options.loop; | |||
vid.muted = !!this.options.muted; | |||
vid.playsInline = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this an option like all the other ones, there might be use-cases where someone would actually want to have this play in full-screen.
Here a link to test on a mobile device: http://falke-design.bplaced.net/leaflet/video/videooverlay.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Falke-Design could you rebase this on |
@jonkoops does it work? |
Strangely enough it reports a smaller size, which seems impossible. I'll wait for some more PRs so we can see is this is a persistent problem. |
The main PR was closed because we renamed the
master
branch tomain
.For more infos look into: #7364
Fixes #7357