Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update marker: role=button, alt=marker #7895

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Update marker: role=button, alt=marker #7895

merged 2 commits into from
Jan 10, 2022

Conversation

tmiaa
Copy link
Contributor

@tmiaa tmiaa commented Jan 9, 2022

Marker is set to alt=marker and role=button to Fix #7428 and now it's possible to open the pop-ups with my screen reader, it's not possible here: https://leafletjs.com/examples/quick-start/

mourner
mourner approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! cc @Malvoz

@Falke-Design Falke-Design added the accessibility Anything related to ensuring no barriers exist that prevent interactions or information access label Jan 10, 2022
Malvoz
Malvoz approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a much better default. Thanks!

@mourner mourner merged commit 10d0031 into Leaflet:master Jan 10, 2022
@Malvoz Malvoz mentioned this pull request Jan 13, 2022
Closed
@Malvoz Malvoz mentioned this pull request Feb 8, 2022
Closed
@Falke-Design Falke-Design mentioned this pull request Feb 24, 2022
Closed
@Malvoz Malvoz mentioned this pull request Apr 4, 2022
Open
This was referenced May 20, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Falke-Design Falke-Design Falke-Design left review comments

@jonkoops jonkoops jonkoops left review comments

@Malvoz Malvoz Malvoz approved these changes

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
accessibility Anything related to ensuring no barriers exist that prevent interactions or information access
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interactive markers should have an accessible name and role="button"
5 participants
@tmiaa @mourner @jonkoops @Falke-Design @Malvoz