Better disableClickPropagation #7751
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disableClickPropagation does not prevent click on element's feature.
This was referenced Nov 7, 2021
… (and child elements)
johnd0e
force-pushed
the
betterDisableClickPropagation
branch
2 times, most recently
from
d1e3dfe to
488b3bd
Compare
- Leave DomEvent.disableClickPropagation as is (but w/o of legacy click tricks) - Introduce special method Evented.disableClickPropagation Note: Control.* should use DomEvent.disableClickPropagation
johnd0e
force-pushed
the
betterDisableClickPropagation
branch
from
488b3bd to
366698b
Compare
|
Alternative solution in last commit (actually I'm not sure that it is better).
Note: Control.* should use DomEvent.disableClickPropagation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
disableClickPropagationdoes not prevent events on elements' featureFix #7750