Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload artifacts from CI #7691

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Upload artifacts from CI #7691

merged 1 commit into from
Oct 19, 2021

Conversation

jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Oct 7, 2021

Allows artifacts from the build to be uploaded to an S3 bucket, same as Travis would do. This change is needed to facilitate the switch from Travis to Github Actions as described in #7611.

The artifacts will be uploaded for any commit that is made on the master branch, or if a version is tagged. In order for this change to work the following secrets will have to be added to the repository:

  • AWS_S3_BUCKET
  • AWS_ACCESS_KEY_ID
  • AWS_SECRET_ACCESS_KEY

More information about these variables can be found in the documentation of the action used to upload the artifacts.

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mourner mourner merged commit 90fb75a into Leaflet:master Oct 19, 2021
@jonkoops jonkoops deleted the feature/upload-artifact branch November 1, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants