Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on browsers instead of PhantomJS #7660

Merged
merged 2 commits into from
Sep 6, 2021
Merged

Run tests on browsers instead of PhantomJS #7660

merged 2 commits into from
Sep 6, 2021

Conversation

jonkoops
Copy link
Collaborator

@jonkoops jonkoops commented Sep 6, 2021

Follow up on #7654 to allow tests to run on actual browsers instead of on PhantomJS.

@jonkoops jonkoops marked this pull request as ready for review September 6, 2021 14:18
@jonkoops
Copy link
Collaborator Author

jonkoops commented Sep 6, 2021

@mourner This change allows the tests to run properly on the different browsers. I've also added a change to the on section to run the tasks on a PR as simply providing push was not enough to actually start the build.

@mourner mourner merged commit d6d6051 into Leaflet:master Sep 6, 2021
@jonkoops jonkoops deleted the feature/ci-on-browsers branch September 6, 2021 22:32
Qdigital added a commit to Qdigital/Leaflet that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants