-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add accessibility section to plugins guide #7277
Conversation
May I ask for a review of this PR? 🙏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no problems with adding this to the documentation.
For me personally: The links are very "hard to read" and I don't think that a new plugin contributer will read through it. It would be good if there would be a list of common mistakes (specially for Leaflet) and / or maybe a link to a docu which explains the first steps and the important information about this topic. Do you understand what I mean?
Apart from this PR, would you have the time to create PRs for each accessibility issue? If not it would be very helpful if you can write into the issues what should be changed (from this into this), then we create PRs
Thanks for the feedback @Falke-Design.
Those documents are authoritative and are often referred to in the accessibility dev world, but they may take some time getting used to. I don't expect developers to read it all, but more so for them to know that they're there, and that they mean something. And they can choose to use them (and learn how to use them) if they wish. Perhaps they should be replaced with- or accompanied by e.g.:
That second resource even covers what we're discussing here 😋:
(https://github.com/mfairchild365/a11y-resources#standards)
I did consider that, but how many would be enough, or too few? Generally the issues in Leaflet and plugins are issues that are common to all web sites. I.e. issues with: focus delegation, focus visibility, missing accessible names (and then I suppose I'd have to explain what an accessible name is and that it may be derived from: text from element/ |
I believe each issue should have a proposed solution already. I will try to find time to look over the issues tomorrow to clarify them, perhaps by using headings, such as "Motivation" and "Solution". 👍 |
Good point 👍
Yes I understand. I looked into your links and they have so much informations, that I closed the sites fast again 😉 But you are right there are enough tools out there. And you added already a good list to start.
Thanks. I think you have the most experience so it would be good to have clear suggestions and then we can change this in Leaflet 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I think this is a good addition as is, it could be tweaked later if necessary. |
Increase awareness and advocate for accessible content from plugin authors.