Fix tutorials #7014
Merged
Fix tutorials #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Mar 11, 2020
You're welcome, I am a fan of this lib :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to improve tutorials (#4239) and should fix #6927 with updated WMS tutorial.
Small update to CONTRIBUTING.md as I had some issues with the steps to install jekyll
Update to the Mobile tutorial to avoid JS error when device orientation is not supported
WMS tutorial revamp:
The current WMS demo server is no longer available. I found a free WMS service from Mundialis . If necessary I can contact them to make sure this is ok to use it.
For the most part, I kept the same original tutorial structure and I added a brief explanation on WMTS at the beginning. However, I could not find a service for the WTS part, so I removed the example and kept the theoritical explanations (I wonder if WTS is still relevant).
I checked the other tutorials and didn't find more issues.
This is my first PR on an open source project ;)