Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented missing logic for noMoveStart when using panTo function #6685

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

Chivano
Copy link
Contributor

@Chivano Chivano commented Jun 2, 2019

Fixed the open issue #5396 where Map.panTo didnt respect the option noMoveStart as documented in the API documentation

Copy link

@jeffschuler jeffschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes this issue for me. Thanks!

jeffschuler added a commit to cleveland-metroparks/trailsforthepeople that referenced this pull request Oct 4, 2019
Copy link
Collaborator

@johnd0e johnd0e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to pass unneeded options.

src/map/Map.js Outdated Show resolved Hide resolved
src/map/Map.js Outdated Show resolved Hide resolved
src/map/Map.js Outdated Show resolved Hide resolved
@johnd0e johnd0e linked an issue Apr 16, 2020 that may be closed by this pull request
@Falke-Design
Copy link
Member

@Chivano can you please add the suggested changes

@Falke-Design Falke-Design added this to the 1.8.1 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map.flyTo does not respect Pan options noMoveStart
6 participants