Fix Missing Tiles Error #5381 While Maintaining Zoom Experience #5622 #5634
Conversation
|
@mourner if you have the time, could you check that this looks sane to you as well? |
|
By accident, I stumbled upon this old comment from myself a couple of years ago: #3002 (comment)
Looks like we've gone a long way to find out that yes, they probably should. 😄 |
|
Merging this and hoping for the best. Thanks again, @oliverheilig. Sorry this has dragged out for a while, I forgot about this still being open during my vacation. It would have been great if this had been merged before 1.2.0... |
|
@perliedman I remember this post http://leafletjs.com/2016/09/27/leaflet-1.0-final.html and the part about new release cycle and I was really excited that you guys decided to switch the mindset to have shorter release cycles and smaller bugfix releases. So maybe after a week or two it would be a perfect time to do a release for version It really is much more fun when new releases comes out more often and the bugs are squashed. Then you are able to remove those ugly hacks you have added just for the sake of fixing things till the next release of the library you use. Keep up the good work 👍 |
Ok,
i reverted the changes from #5431 and tracked down the true error of #5381: on _abortLoading() the incomplete tiles were removed as DOM-element, but not from the _tiles collection, which left them in a kind of zombie-state. So this now fixes #5381 while maintaining the behaviour mentioned at #5622.
You can test the (hopefully final) version here: http://176.95.37.29/vectortest/missing-tiles-fixed3.html
Hope everyone is happy now 😅