-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent exception if no callback is provided #5225
Conversation
Hi @Benvorth, can you provide a use case where |
If you use
|
I feel that the client code shouldn't be calling this method with I don't see this is leaflets responsibility to handle. It seems like better behavior that you get an error rather than having an erroneous call silently handled. |
Hi there! I'm having the same error and it is very discrourage me in my progress. What am I doing wrong when adding MapLayer to map? My
My
Nothing from this not working (createLeafletElement & componentWillMount) becouse the map is null after the moment of mounting MapContainer component, Could you give the community the correct way of creating this element (I think it's not really hard, but can't find the solution for now). Thanks for this library! |
@seclace hi! Please Note that this is an issue tracker, not a support forum. Unfortunately we don't have the time and resources to dig into other peoples code, especially not when it involves a lot of other libraries which we might not have experience with - for example react-leaflet, in this particular case. Having said that, looking at the screenshots, it looks like the So, given the naming ( |
Thinking about this, we could make sure to throw an error if what's being added doesn't have a |
No description provided.