Only stop "preclick" on popup open for markers #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We actually do not toggle the popup on click for L.Path.
|
Let's revisit after rc3. I'm up to an option and on by default for everything. |
|
The inconsistency has been bothering users of: my app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually do not toggle the popup on click for L.Path.
Fixing what is described here #3992 (comment)
Side note: I'm not a big fan of having the "toggling" only for Marker and not for Path. It's not consistent as a UX and it introduce ugly
ifin the code.What about instead having it by default for all layers, and adding an option (
toggleOnClick) to opt-out?