Fix canvas not filtering click event after drag #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great work, i tried this fix and it works like a charm |
| @@ -253,7 +253,7 @@ L.Canvas = L.Renderer.extend({ | |||
|
|
|||
| for (var id in this._layers) { | |||
| layer = this._layers[id]; | |||
| if (layer.options.interactive && layer._containsPoint(point)) { | |||
| if (layer.options.interactive && layer._containsPoint(point) && !this._map._draggableMoved(layer)) { | |||
There was a problem hiding this comment.
Might it be possible to just remove the click listener while the map is dragged? I guess that would make it a bit clearer what's going on, and make it less coupled with Map's internals.
|
Damn, squashed accidentally — sorry! The commit has a link to PR and a summary though. @perliedman this may be a better approach — let's follow up if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4458
The issue come from the fact that we compute targets in a different way while in canvas or vector DOM, but we were now checking for drag only in the DOM scenario.
I've tried to refactor a bit to get the check only once, but I think this is not doable given that we are computing the targets in two totally distinct ways.
Note to @IvanSanchez I've added a
happen.clickon the test to simulate theclickevent after down/up, I'm open to a better suggestion :)This PR also fixes
preclicknot being fired by canvas layers. It's in a separate commit and I think it should stay separate and not be rebased.