-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop drag propagation #4250
Stop drag propagation #4250
Conversation
Gratulerer i ditt første pull request :-) I see a couple of issues, though:
|
Thanks for your guidance @IvanSanchez :-) I'll try to get this right.
How would you do this check? |
It's right there on |
This may affect dragging behavior in some browsers so let's test extensively before merging. |
The event now stops to propagate after the three return statements, and I've checked that it still solves the issue. |
@turban please squash into one commit. |
I have some troubles squashing the commits of this pull requests, so I'm creating a new one. |
New pull request with one commit: #4306 |
This commit fixes #4249