Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop drag propagation #4250

Closed
wants to merge 6 commits into from
Closed

Conversation

turban
Copy link
Contributor

@turban turban commented Feb 16, 2016

This commit fixes #4249

@IvanSanchez
Copy link
Member

Gratulerer i ditt første pull request :-)

I see a couple of issues, though:

  • The unit tests fail (check the travis details, run npm test locally next time)
  • You have several whitespace-only commits, which you should probably squash into one
  • Stopping propagation of the event should be done only if the drag is going to start - in other words, do not stop propagation if I'm holding the shift key or dragging with the right mouse button

@turban
Copy link
Contributor Author

turban commented Feb 16, 2016

Thanks for your guidance @IvanSanchez :-) I'll try to get this right.

Stopping propagation of the event should be done only if the drag is going to start - in other words, do not stop propagation if I'm holding the shift key or dragging with the right mouse button

How would you do this check?

@IvanSanchez
Copy link
Member

How would you do this check?

It's right there on _onDown, a few lines down. Look closer ;-)

@mourner
Copy link
Member

mourner commented Feb 16, 2016

This may affect dragging behavior in some browsers so let's test extensively before merging.

@turban
Copy link
Contributor Author

turban commented Feb 16, 2016

The event now stops to propagate after the three return statements, and I've checked that it still solves the issue.

@mourner
Copy link
Member

mourner commented Mar 3, 2016

@turban please squash into one commit.

@turban
Copy link
Contributor Author

turban commented Mar 7, 2016

I have some troubles squashing the commits of this pull requests, so I'm creating a new one.

@turban turban closed this Mar 7, 2016
@turban turban deleted the stop-drag-propagation branch March 7, 2016 11:43
@turban
Copy link
Contributor Author

turban commented Mar 7, 2016

New pull request with one commit: #4306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to stop map drag propagation
3 participants