Fix event target fallbacking to map after marker drag (fix #3971) #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't recall :( |
yohanboniface
force-pushed
the
dragend-click
branch
from
8a3506a to
64484d5
Compare
|
@yohanboniface |
|
@yohanboniface Not the cleanest PR ever (I wouldn't expect less from a 'brainmelt' tag ;-) ) but looks good to me. |
IvanSanchez
added a commit
that referenced
this pull request
Jan 8, 2016
Fix event target fallbacking to map after marker drag (fix #3971)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3971
Given that the dragged marker was not listening to click events,
_findEventTargetswas using current map instance as default (which is the normal behaviour) target, but then in_fireDOMEventwe were not checkingdraggableMovedwith the real event target.@mourner
e._simulatedcomes from f9ea475, but I don't get why we needed and still need it when checking fordraggableMoved, do you recall? :)