issue #3995 fixed check for maxZoom option to honor maxZoom 0 #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if maxZoom is a number will work fine for {maxZoom: 0} where
options.maxZoom evaluates to false.
|
Hi there, I have the same fix ready for the master branch. If this one is okay I'd be happy to create a pull request for the master branch as well. I'm contributing here for the first time and not too familiar with GitHub and the rules here, yet. Just let me know in case I did something wrong :-) |
This was referenced Nov 9, 2015
IvanSanchez
added a commit
that referenced
this pull request
Nov 10, 2015
issue #3995 fixed check for maxZoom option to honor maxZoom 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if maxZoom is a number will work fine for {maxZoom: 0} where
options.maxZoom evaluates to false.