init interaction regardless of new icon or not #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[issue #3976] previously interaction only get inited when not reusing icon, i.e. when addIcon flag is set to true. by taking the statement out of the if condition, interaction is inited whenever setIcon is called.
|
Seems to work fine. Thanks, @celadevra ! |
IvanSanchez
added a commit
that referenced
this pull request
Nov 2, 2015
init interaction regardless of new icon or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[issue #3976]
previously interaction only get inited when not reusing icon, i.e. when
addIconflag is set to
true. by taking the statement out of the if condition,interaction is inited whenever
_initIconis called.