-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L.Layer and L.Evented docs #3097
Conversation
Awesome, will look this through!
Conceptually, the Layer class is now in place of ILayer. Earlier you needed to conform to an interface for custom layers, now you're required to inherit from Layer. |
Technically aren't both true? You now require to inherit from L.Layer AND implement What about splitting up "Utilities" and "Interfaces" into "Utilities" and "Base Classes"? Since for every interface you are now required to extend from a base class and implement specific methods, Utilities
Base Classes
|
Yeah, you're right. Although this time we can get rid of the "interface" concept in docs alltogether, making things simpler to understand, because these interfaces are not sophisticated anymore — we can add a section on custom use of each class like L.Layer without calling it an interface in the table of contents. I like the "Base Classes" suggestion. |
I'll split this up into "Utilities" and "Base Classes" and update this PR. |
This is now a pretty huge PR so it would be great if @mourner, @danzel or someone could look over the changes so I can continue to base future docs on this set of changes. |
Rebased and merged to |
Document the new
L.Layer
andL.Evented
classes for 1.0. This documents some of major changes for in https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md#layers-refactoring.I wasn't quite sure where to put the docs for
L.Layer
, I've added them here under "Utility" but They might be better documented under "ILayer" but I'll leave it split up for now and we can discuss.Can @mourner and/or @danzel review?