-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations 2.0 (fractional zoom, pyramid tiles & zoomPanTo) #2382
Conversation
Just looked at and tested your modification. It is stable and fast. No problems with android devices so far. Looking foward to your zoom pinch solution for touch devices. |
There is currently a problem with loading tiles on fractional zoom levels. |
@gouilaz works for me, is this always reproduced for you given those steps? |
@mourner: That is strange. It happens in all my desktop browsers. I was able to reproduce this bug in Chrome, IE11, Firefox and Safari (latest versions). I am using Windows 7. Can anybody else confirm if this is a real bug or just my machine? |
Yeah, I see the bug now, I just didn't understand steps to reproduce initially. |
@gouilaz fixed tiles not loading issue and some others, should work a bit better now. |
@mourner have tested your newest build and it works very well so far. The tiles load up without any problems. |
Reworked fractional zoom support and animations more, now working on pyramid tiles. |
The zoomPan stuff looks soo good! Great work @mourner ! |
🍻 I'm really excited for this. |
@mourner this is looking really good. It would be great to implement an API for calling intermediate steps in zoomPanTo, similar to ease.t and ease.future in easey.js. My use case is attaching map zoom to page scroll, as implemented in http://digidem.github.io/clearwater-map (currently using ModestMaps.js and easey.js) |
@mourner This is looking really really great! I tested this new feature and this is smooth. I wanted to test this with the latest mapbox.js in standalone version.
But I got js errors when creating the map. Is there a way to test this with mapbox.js ? |
@mrdoinel there should be a branch (0.8-dev or something like that) that works with Leaflet master, try that. |
@mourner Any news on a next code update? Looks great so far. |
Yeah, will get back to this in a few days in case Kiev is not invaded by Russians :) |
@mourner stay safe man! Looking forward to seeing the fractional zoom in action. Is this last task the only piece left or is it also dependent on the pyramid tiles piece?
|
@cjbraden this one is independent, but there are some more difficult things to implement before we can merge (tile management, stoppable transitions, better scroll-zoom). |
Rebased on top of master to fix some issues. |
I noticed that the layers control is broken on the easy branch. After you toggle base layers once, they no longer appear. |
@jfirebaugh tile layer removal is broken probably, will look into this, thanks |
Mapbox.js examples that don't work: Disable world wrapping, Firebase, Point in Polygon, Markercluster, Leaflet Label, Leaflet Image, Leaflet Heat. |
@jfirebaugh hmm, that's too many. Any particular things why they don't work? |
Except for world wrapping they are all plugin incompatibilities. |
F**k it, merged. Working on any outstanding problems in the master branch, — please report issues as necessary. |
Oh yeah! Amazing news :-) |
👏 👏 👏 |
Awesome |
Thanks @mourner! |
Is that 0.7.4 / 0.8 version out yet? |
No. |
Is there a milestone / issue I can track to see progress on how close that would be to happening? |
Is this feature zoomPanTo in master currently? It shows as merged above but I can't find "zoomPanTo" in build/leaflet.js after running jake. |
Wasn't it renamed to flyTo() ? — On Thu, Nov 27, 2014 at 10:51 AM, Alex Crooks notifications@github.com
|
So was 0.8 renamed to 1.0? |
0.8 -> 1.0 yep |
Hi guys, Any news about the fractional zoom feature ? Do you have an estimation date for a beta release ? Thanks, |
zoomPanTo
.map.zoomPanTo
) animates smoothly between two locations no matter how distant they are through the shortest zoom-pan curve. map.zoomPanTo() #141313.57
, scaling tile layers from round zooms when necessary. Fractional zoom support #607 Added zomeTune feature and continuous zoom #1941 Support more granularity in zoom levels #1309 Changing to an unsupported tile provider zoom level removes all tiles and reports a load of errors #1934Pyramid tile loading and animation
Easey-style zoomPanTo (optimal path zoom animations)
Fractional zoom support