Don't fade in a currently shown popup when clicking marker again #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about the open/close behavior, I'll merge this for now and decide later. :) Thanks! |
mourner
added a commit
that referenced
this pull request
Feb 15, 2013
Don't fade in a currently shown popup when clicking marker again
|
If I clicked on a marker with an open popup I would expect the popup to close, especially since hovering over the marker changes the cursor to a hand pointer. If it stays the same, the cursor should be changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking an marker with an open popup causes the popup to fade in again.This disables that.
References issue #560.
(@mourner, if you would rather make it close instead, as was mentioned as one of the ideas in the issue, let me know.)