Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow HTML in Layer Names (issue #1009) #1055

Merged
merged 2 commits into from
Oct 15, 2012

Conversation

aparshin
Copy link
Contributor

@aparshin aparshin commented Oct 9, 2012

I've changed CSS to prevent apply Leaflet styles to possible <a> and <input> elements inside layer names.

@mourner
Copy link
Member

mourner commented Oct 10, 2012

Whitespace is broken in your pull, please run jake lint and fix all the issues.

@aparshin
Copy link
Contributor Author

jake lint
Checking for JS errors...
        Check passed

What issues do you mean? Whitespaces usage instead of tabs? "smarttabs" option in jshint config (build/hintrc.js) is set to "true"...

@mourner
Copy link
Member

mourner commented Oct 10, 2012

Don't know why JSHint doesn't throw an error, but take a look at your code:
https://github.com/aparshin/Leaflet/blob/20915a83fa98233ce66b3d855dcc77322cd0c3cc/src/control/Control.Layers.js#L159

(this line and also several lines lower)

@aparshin
Copy link
Contributor Author

Fixed! Looks like JSHint really can't check what exactly symbols are used for indent (spaces or tabs)...

mourner added a commit that referenced this pull request Oct 15, 2012
@mourner mourner merged commit 09060ff into Leaflet:master Oct 15, 2012
@mourner
Copy link
Member

mourner commented Oct 15, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants