Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(TileLayer.WMS & Canvas): get rid of calls to global L #6048

Merged
merged 2 commits into from
Feb 12, 2018
Merged

Fix(TileLayer.WMS & Canvas): get rid of calls to global L #6048

merged 2 commits into from
Feb 12, 2018

Conversation

ghybs
Copy link
Collaborator

@ghybs ghybs commented Feb 12, 2018

This simple PR is similar to #6047.

It gets rid of leftover calls to global L:

These should be the last references to global L, apart from L.Mixin in checkDeprecatedMixinEvents of Class, which refers to it on purpose.

ghybs added 2 commits February 12, 2018 16:10
@ghybs
Fix(TileLayerWMS): get rid of L.TileLayer global call
563ea26 
and rely on imported TileLayer instead.
@ghybs
Fix(Canvas): get rid of L.stamp global call
da31748 
and rely on imported Util.stamp instead.
@cherniavskii cherniavskii merged commit fa374e6 into Leaflet:master Feb 12, 2018
@ghybs ghybs deleted the globalCallsL branch February 12, 2018 13:28
@snyk-bot snyk-bot mentioned this pull request Sep 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghybs @cherniavskii