-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs redirects #5824
Merged
Merged
Docs redirects #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use relative links instead of absolute - remove hardcoded version in lins and refer to latest version docs instead
- use relative links instead of absolute
IvanSanchez
approved these changes
Oct 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice, should close #5508 if I understand correctly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5493
jekyll-redirect-from
was added for redirects, and it works.But there are links to docs with hash params in examples, which are all redirected to
http://leafletjs.com/reference-1.2.0.html
instead ofhttp://leafletjs.com/reference-1.2.0.html#hash
.See
L.Icon
link in Custom Icons example.Since
jekyll-redirect-from
does not preserve hash params, I removed it and usedredirected.html
layout, which I modified to preserve hash params.I also fixed some absolute links, and changed some links from specific docs version to latest.
So now it is possible to refer latest docs with hash like that:
and it will redirect to docs version defined in main reference.html file.
Tested locally, it should work.