use zoom parameter if passed #5822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Oct 4, 2017
|
Unfortunately it breaks TileLayer's zoomOffset option. #6004 |
|
Hi, Thank you @lpikora for pointing out that PR!
Sounds to me that the proper place for such a modification / override for that purpose might have been in But in the first place, I think we could have spotted the regression earlier should this PR have been first reported as an issue, with all required information in it (in particular: Leaflet version, bug description and minimal test case reproduction), and this PR had included a test spec. Follow-up of corrective action in issue #6004. |
2 tasks
yohanboniface
added a commit
that referenced
this pull request
Dec 28, 2023
cf #6004 #6006 Before this change, `coords.z` would not taken into account, and was always overriden by `this._tileZoom`. In the normal flow, `coords.z` is anyway set from `this._tileZoom` before `getTileUrl` is called (in GridLayer._update). But this prevents using `getTileUrl` out of this `_update` method. There are some scenarios where this is needed (see #5822), or (which is the case in uMap) when wanting to display a tile as a tilelayer preview.
yohanboniface
added a commit
that referenced
this pull request
Dec 28, 2023
cf #6004 #6006 Before this change, `coords.z` would not taken into account, and was always overriden by `this._tileZoom`. In the normal flow, `coords.z` is anyway set from `this._tileZoom` before `getTileUrl` is called (in GridLayer._update). But this prevents using `getTileUrl` out of this `_update` method. There are some scenarios where this is needed (see #5822), or (which is the case in uMap) when wanting to display a tile as a tilelayer preview.
yohanboniface
added a commit
that referenced
this pull request
Dec 28, 2023
cf #6004 #6006 Before this change, `coords.z` would not taken into account, and was always overriden by `this._tileZoom`. In the normal flow, `coords.z` is anyway set from `this._tileZoom` before `getTileUrl` is called (in GridLayer._update). But this prevents using `getTileUrl` out of this `_update` method. There are some scenarios where this is needed (see #5822), or (which is the case in uMap) when wanting to display a tile as a tilelayer preview.
Falke-Design
pushed a commit
that referenced
this pull request
Jul 7, 2024
cf #6004 #6006 Before this change, `coords.z` would not taken into account, and was always overriden by `this._tileZoom`. In the normal flow, `coords.z` is anyway set from `this._tileZoom` before `getTileUrl` is called (in GridLayer._update). But this prevents using `getTileUrl` out of this `_update` method. There are some scenarios where this is needed (see #5822), or (which is the case in uMap) when wanting to display a tile as a tilelayer preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an offline layer, which caches the tiles and we need to generate URL for various zoom level (https://github.com/mWater/offline-leaflet-map). We did override this method there but I think this should also be supported in leaflet itself!
It only supplies the z parameter from the current zoom level of the map right now