Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VideoOverlay.js #5731

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Update VideoOverlay.js #5731

merged 2 commits into from
Aug 28, 2017

Conversation

Dzwiedzminator
Copy link
Contributor

wrong keyword uses - className should be used instead
found this when testing new leaflet on ie8 - map doesn't load because of this

wrong keyword uses - className should be used instead
found this when testing new leaflet on ie8 - map doesn't load because of this
@IvanSanchez
Copy link
Member

Hhhmm, nice catch! Apparently this was introduced by #5661.

I guess it would be better to use L.DomUtil.addClass() instead - if the user is providing an instance of HTMLVideoElement, overwriting the existing CSS classes of that DOM element looks like a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants