Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5534 by adding a check for null. #5535

Merged
merged 3 commits into from
Jun 1, 2017
Merged

Fixes #5534 by adding a check for null. #5535

merged 3 commits into from
Jun 1, 2017

Conversation

williamscs
Copy link
Contributor

I can't figure out a good way to add a regression test for this. Any help on that would be appreciated.

@williamscs williamscs mentioned this pull request May 30, 2017
Closed
perliedman
perliedman approved these changes Jun 1, 2017
View reviewed changes
Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I agree that I can't come up with a good solution to emulating the DOM not being loaded yet, so lets leave testing up to the next time we hit a snag here.

There are already some tests that exercise this code, so it should be ok.

@perliedman perliedman merged commit 0b9464f into Leaflet:master Jun 1, 2017
@ghybs ghybs mentioned this pull request Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perliedman perliedman perliedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamscs @perliedman @mourner