IE fixes for new control styles. #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about the last-child thing... Is a 1px bottom border really affecting IE6-7 zoom control appearance enough to justify complicating the DOM generating code of controls? Everything else looks good! |
|
Cool , I'm totally fine with that. The 1 pixel doesn't really make it look too bad. I'll back out the change tomorrow. |
|
Ok backed out the last-child fix. |
mourner
added a commit
that referenced
this pull request
Jan 29, 2013
IE fixes for new control styles.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few fixes for IE.
I added back in a class for the last bar button as
last-childdoesn't work in < ie 8 (http://caniuse.com/#search=last-child). Didn't need to fixfirst-childas the only style it applies isborder-radius.