Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

chore: add nvm support #3784

Merged
merged 1 commit into from
Jan 12, 2022
Merged

chore: add nvm support #3784

merged 1 commit into from
Jan 12, 2022

Conversation

escapedcat
Copy link
Contributor

Description:

  • Support for nvm
    It will automatically use node v12 if you are using nvm.
    Everything works like before if you don't use nvm. It's fine.
  • Minor format changes on the README due to prettier-plugin. I can revert these if wanted
  • Also update link to install link for yarn v1, because that's now the classic-version

Motivation and Context:

nvm helps people like me to on their first install

How Has This Been Tested?

Did yarn with current node v12 and yarn dev

Types of changes:

  • add .nvmrc
  • update docs

Checklist:

  • My code follows the code style of this project.
  • [xI have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@welcome
Copy link

welcome bot commented Jan 12, 2022

⚡️ Thanks for opening this pull request! ⚡️
We use conventional commits to streamline the release process. Before your pull request can be merged, you should squash your commits and reword your commit messages to follow the conventional commit message format.
Examples of commit messages with semantic prefixes:

  • fix(ui): ensure search input is cleared after submit
  • feat(wallet): add new transaction detail view
  • perf(channels): prevent double render in channel list
    Things that will help get your PR across the finish line:
  • Run yarn lint locally to catch formatting errors earlier.
  • Run yarn test locally to catch test failures early.
  • Run yarn extract-messages locally to extract new transaction strings.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

@mrfelton mrfelton merged commit d03d7bc into LN-Zap:master Jan 12, 2022
@welcome
Copy link

welcome bot commented Jan 12, 2022

Congrats on merging your first pull request! ⚡️⚡️⚡️

@escapedcat escapedcat deleted the chore/nvm-support branch January 12, 2022 08:24
@escapedcat
Copy link
Contributor Author

escapedcat commented Jan 12, 2022 •
edited
Loading

@mrfelton you have a suggestion for a "good first issue"? Would like to support a bit more if possible/wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrfelton mrfelton mrfelton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@escapedcat @mrfelton