Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot as abbrev #250

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Dot as abbrev #250

merged 8 commits into from
Dec 2, 2022

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Nov 23, 2022

Address #246. Make the interpretation of '.' in unit strings more consistent and coordinated.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #250 (c778ba5) into main (466438b) will decrease coverage by 0.17%.
The diff coverage is 80.43%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   97.59%   97.42%   -0.18%     
==========================================
  Files          11       11              
  Lines        4583     4621      +38     
==========================================
+ Hits         4473     4502      +29     
- Misses        110      119       +9     

@phlptp phlptp merged commit 296dab0 into main Dec 2, 2022
@phlptp phlptp deleted the dot_as_abbrev branch December 2, 2022 15:35
@SimonHeybrock
Copy link
Contributor

Thanks, do you plan to make a new release with these changes?

@phlptp
Copy link
Collaborator Author

phlptp commented Dec 5, 2022

I will soon, will probably try to bump up the coverage a little before making another release likely before Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants