-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use compound vec in bicg IR #621
Conversation
src/Optimization/hiopKKTLinSys.cpp
Outdated
dir_ir.getVector(0).copyFrom(*dx_); | ||
dir_ir.getVector(1).copyFrom(*dd_); | ||
dir_ir.getVector(2).copyFrom(*dyc_); | ||
dir_ir.getVector(3).copyFrom(*dyd_); | ||
dir_ir.getVector(4).copyFrom(*dsxl_); | ||
dir_ir.getVector(5).copyFrom(*dsxu_); | ||
dir_ir.getVector(6).copyFrom(*dsdl_); | ||
dir_ir.getVector(7).copyFrom(*dsdu_); | ||
dir_ir.getVector(8).copyFrom(*dzl_); | ||
dir_ir.getVector(9).copyFrom(*dzu_); | ||
dir_ir.getVector(10).copyFrom(*dvl_); | ||
dir_ir.getVector(11).copyFrom(*dvu_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order to build the compound vector is hard-coded
. Should we use unordered_map to avoid this? @cnpetra
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still a draft PR. If we agree to this implementation, I will clean the code and add some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the order to build the compound vector is
hard-coded
. Should we use unordered_map to avoid this? @cnpetra
I was thinking to use a PrimalDualVector
class instead of the so-called compound. It may not covered all the use cases though...
CLOSE #630