Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch hip::device target to allow compilation/running without FindHIP #541

Merged
merged 8 commits into from
Nov 8, 2021
Merged

Patch hip::device target to allow compilation/running without FindHIP #541

merged 8 commits into from
Nov 8, 2021

Conversation

joshessman-llnl
Copy link
Member 

$ ml cmake/3.21
$ cmake -C host-configs/llnl/toss_4_x86_64_ib_cray/cce@12.0.3_clang_hip.cmake tests/internal/
$ make blt_hip_smoke
$ ctest -R blt_hip_smoke -VV
...
test 11
    Start 11: blt_hip_smoke

11: Test command: /g/g16/essman1/axom/src/cmake/blt/tests/build/tests/blt_hip_smoke
11: Test timeout computed to be: 1500
1/1 Test #11: blt_hip_smoke ....................   Passed    0.03 sec

The following tests passed:
	blt_hip_smoke

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.05 sec

@joshessman-llnl joshessman-llnl added the hip Related to AMD hip label Nov 3, 2021
kennyweiss
kennyweiss approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@kennyweiss kennyweiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshessman-llnl !

Some notes:

  • Did you also check this against cmake@3.19?
  • This PR will be easier to review once the parent PR merges in the develop branch.
    EDIT: The parent branch was updated. Can you please rebase/merge this branch against that one?

host-configs/llnl/toss_4_x86_64_ib_cray/cce@12.0.3_clang_hip.cmake Outdated Show resolved Hide resolved
host-configs/llnl/toss_4_x86_64_ib_cray/cce@12.0.3_clang_hip.cmake Show resolved Hide resolved
cmake/thirdparty/SetupHIP.cmake Show resolved Hide resolved
cmake/thirdparty/SetupHIP.cmake Outdated Show resolved Hide resolved
@joshessman-llnl joshessman-llnl merged commit 75a48a4 into feature/no-findhip Nov 8, 2021
@joshessman-llnl joshessman-llnl deleted the bugfix/patch-hip-device branch November 8, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyweiss kennyweiss kennyweiss approved these changes

@davidbeckingsale davidbeckingsale davidbeckingsale approved these changes

Assignees
No one assigned
Labels
hip Related to AMD hip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshessman-llnl @davidbeckingsale @kennyweiss