Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Add instructions for adding and editing translations #1120

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

rjmacarthy
Copy link
Contributor

@rjmacarthy rjmacarthy commented Feb 4, 2023

#1083

This pull requests adds instructions on how to add translations to the website project. This PR also includes a script which can be run to find missing and potentially untranslated entries in all locales.

@github-actions
Copy link

github-actions bot commented Feb 4, 2023

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@rjmacarthy rjmacarthy force-pushed the docs/add_edit_translations branch from ccf4613 to 1618681 Compare February 4, 2023 20:05
@rjmacarthy rjmacarthy changed the title website: Add instructions for adding and editing translations #1083 website: Add instructions for adding and editing translations Feb 4, 2023
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

scripts/frontend-development/find-missing-locales.py Outdated Show resolved Hide resolved
Pre-commit

update markdown

Remove ignore_keys
@rjmacarthy rjmacarthy force-pushed the docs/add_edit_translations branch from 1618681 to 17923a4 Compare February 4, 2023 21:01
Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@AbdBarho AbdBarho merged commit dc6dd6a into LAION-AI:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants