Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade the appconfiguration generator framework #573

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: upgrade the appconfiguration generator framework #573

merged 2 commits into from
Oct 31, 2023

Conversation

Wenfeng-GAO
Copy link
Contributor

Refs: #529

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Refs #529

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:

- [Design]: <https://github.com/KusionStack/kusion/pull/565/files>

@Wenfeng-GAO Wenfeng-GAO force-pushed the appconfiguration-generator-refactor-br branch 2 times, most recently from 25c13ac to 8b3b4b9 Compare October 26, 2023 09:19
@elliotxx
Copy link
Contributor

elliotxx commented Oct 27, 2023 •
edited
Loading

Need to repair the unit test 👇🏻

@Wenfeng-GAO Wenfeng-GAO force-pushed the appconfiguration-generator-refactor-br branch 4 times, most recently from 0880e6a to 20750cc Compare October 30, 2023 07:04
@coveralls
Copy link

coveralls commented Oct 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6701471491

  • 100 of 128 (78.13%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 75.459%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/app_configurations_generator.go 6 8 75.0%
pkg/generator/appconfiguration/generator/trait/ops_rule_patcher.go 19 21 90.48%
pkg/generator/appconfiguration/util.go 26 37 70.27%
pkg/generator/appconfiguration/generator/monitoring_patcher.go 36 49 73.47%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/generator/appconfiguration/generator/app_configurations_generator.go 1 83.61%
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 6662527723: 0.06%
Covered Lines: 6912
Relevant Lines: 9160
💛 - Coveralls

elliotxx
elliotxx previously approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SparkYuan
SparkYuan requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

71 of 128 (55.47%) changed or added relevant lines in 6 files are covered.

Test coverage is too low, please add more test cases.

@Wenfeng-GAO Wenfeng-GAO force-pushed the appconfiguration-generator-refactor-br branch 2 times, most recently from ae90d05 to 2d94693 Compare October 31, 2023 02:58
@Wenfeng-GAO Wenfeng-GAO force-pushed the appconfiguration-generator-refactor-br branch from 2d94693 to 762d3a4 Compare October 31, 2023 11:54
SparkYuan
SparkYuan previously approved these changes Oct 31, 2023
View reviewed changes
@SparkYuan SparkYuan enabled auto-merge (squash) October 31, 2023 13:00
SparkYuan
SparkYuan approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6be5849 into KusionStack:main Oct 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx elliotxx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wenfeng-GAO @elliotxx @coveralls @SparkYuan