Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add local database generator and related unit tests #557

Merged
merged 4 commits into from
Sep 27, 2023
Merged

feat: add local database generator and related unit tests #557

merged 4 commits into from
Sep 27, 2023

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for local database generator and related unit tests.

Which issue(s) this PR fixes:

Fixes #556

Special notes for your reviewer:

An example of deploying WordPress application with local database is shown below.
image

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@liu-hm19 liu-hm19 self-assigned this Sep 25, 2023
@coveralls
Copy link

coveralls commented Sep 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6294593620

  • 210 of 279 (75.27%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 74.556%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/accessories/database/database_generator.go 0 2 0.0%
pkg/generator/appconfiguration/generator/accessories/database/local_database.go 210 277 75.81%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 6258302322: 0.05%
Covered Lines: 6795
Relevant Lines: 9114
💛 - Coveralls

@liu-hm19 liu-hm19 force-pushed the feat/add-local-database-generator branch from bea729f to b8b7482 Compare September 26, 2023 08:05
SparkYuan
SparkYuan approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit e965083 into KusionStack:main Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
@ffforest ffforest linked an issue Oct 7, 2023 that may be closed by this pull request
Model: AppConfiguration model supports local database #480
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@ffforest ffforest Awaiting requested review from ffforest

@elliotxx elliotxx Awaiting requested review from elliotxx

Assignees

@liu-hm19 liu-hm19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model: Add Local Database Generator Model: AppConfiguration model supports local database
3 participants
@liu-hm19 @coveralls @SparkYuan