Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for database generator #546

Merged

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Sep 14, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds unit tests for database generator.

Which issue(s) this PR fixes:

Fixes #541

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 6183128604

  • 5 of 10 (50.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 74.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/accessories/database/database_generator.go 5 10 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 72.03%
Totals Coverage Status
Change from base Build 6181960614: 0.4%
Covered Lines: 6537
Relevant Lines: 8775

💛 - Coveralls

@liu-hm19 liu-hm19 force-pushed the test/add-unit-tests-for-database-generator branch from da3dd53 to d079542 Compare September 15, 2023 03:23
@liu-hm19 liu-hm19 changed the title test: add unit tests for database generator and fix a bug test: add unit tests for database generator Sep 15, 2023
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit cee7537 into KusionStack:main Sep 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing: add unit tests for database generator
3 participants