Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether we still need BeforeResumeCancelHandler #3646

Closed
qwwdfsad opened this issue Feb 27, 2023 · 1 comment
Closed

Investigate whether we still need BeforeResumeCancelHandler #3646

qwwdfsad opened this issue Feb 27, 2023 · 1 comment
Assignees
@qwwdfsad
Labels
enhancement

Comments

@qwwdfsad
Copy link
Contributor

This is an internal API that has been mostly unused since #3084 except for one place.

More codepath to check, more code to test and maintain, more regressions to happen (as the code-path is highly-specific), we should investigate whether it is possible to get rid of it
@qwwdfsad qwwdfsad self-assigned this May 8, 2023
qwwdfsad added a commit that referenced this issue May 10, 2023
@qwwdfsad
Get rid of BeforeResumeCancelHandler
a235fbe 
Fixes #3646
@qwwdfsad
Copy link
Contributor Author

Fixed.
Unfortunately, there is one more allocation left that creates a difference in Channel() and Channel {} characteristics -- resumedState allocation that has non-null onCancellation lambda when used with iterator (hasNextOnNoWaiterSuspend)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qwwdfsad