-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): set txfee for some tbtc tests #2116
Conversation
Some tests still failing due to low tbtc balance/high fees: macos:
windows:
|
…nd_confirmations, alice_can_see_the_active_order_after_orderbook_sync_segwit and test_orderbook_segwit
Fixed them in the latest commit. My initial intention was to fix these tests in a different PR but I fixed them here anyways since they are related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* dev: feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088) fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116)
* dev: feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088) fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116) fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115) fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114) refactor(memory): memory usage improvements (KomodoPlatform#2098) feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102) fix tendermint fee calculation (KomodoPlatform#2106) update dockerfile (KomodoPlatform#2104)
Testnet bitcoin currently has high fees which causes some tests to fail due to not enough balance. Since
test_withdraw_segwit
tests only withdraw and not sending, we can set a fixed fee to fix this test.