Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): set txfee for some tbtc tests #2116

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented May 9, 2024

Testnet bitcoin currently has high fees which causes some tests to fail due to not enough balance. Since test_withdraw_segwit tests only withdraw and not sending, we can set a fixed fee to fix this test.

@shamardy shamardy changed the title fix(tests): set txfee for test_withdraw_segwit instead of estimate_fee_mode fix(tests): set txfee for test_withdraw_segwit May 9, 2024
@shamardy shamardy requested a review from mariocynicys May 9, 2024 14:07
@mariocynicys
Copy link
Collaborator

Some tests still failing due to low tbtc balance/high fees:

macos:

  • mm2_tests::best_orders_tests::best_orders_must_return_duplicate_for_orderbook_tickers

windows:

  • mm2_tests::best_orders_tests::test_best_orders_address_and_confirmations
  • mm2_tests::orderbook_sync_tests::alice_can_see_the_active_order_after_orderbook_sync_segwit
  • mm2_tests::orderbook_sync_tests::test_orderbook_segwit

…nd_confirmations, alice_can_see_the_active_order_after_orderbook_sync_segwit and test_orderbook_segwit
@shamardy
Copy link
Collaborator Author

shamardy commented May 9, 2024

Some tests still failing due to low tbtc balance/high fees:

macos:

  • mm2_tests::best_orders_tests::best_orders_must_return_duplicate_for_orderbook_tickers

windows:

  • mm2_tests::best_orders_tests::test_best_orders_address_and_confirmations
  • mm2_tests::orderbook_sync_tests::alice_can_see_the_active_order_after_orderbook_sync_segwit
  • mm2_tests::orderbook_sync_tests::test_orderbook_segwit

Fixed them in the latest commit. My initial intention was to fix these tests in a different PR but I fixed them here anyways since they are related.

Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamardy shamardy changed the title fix(tests): set txfee for test_withdraw_segwit fix(tests): set txfee for tbtc tests May 9, 2024
@shamardy shamardy changed the title fix(tests): set txfee for tbtc tests fix(tests): set txfee for some tbtc tests May 9, 2024
@shamardy shamardy merged commit 7f08cae into dev May 9, 2024
21 of 27 checks passed
@shamardy shamardy deleted the fix-test-withdraw-segwit branch May 9, 2024 17:37
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 14, 2024
* dev:
  feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088)
  fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116)
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request May 14, 2024
* dev:
  feat(tendermint): pubkey-only activation and unsigned tx (KomodoPlatform#2088)
  fix(tests): set txfee for some tbtc tests (KomodoPlatform#2116)
  fix(eth): remove my_address from sign_and_send_transaction_with_keypair (KomodoPlatform#2115)
  fix(utxo-swap): apply events occurred while taker down (KomodoPlatform#2114)
  refactor(memory): memory usage improvements (KomodoPlatform#2098)
  feat(app-dir): implement root application dir `.kdf` (KomodoPlatform#2102)
  fix tendermint fee calculation (KomodoPlatform#2106)
  update dockerfile (KomodoPlatform#2104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants