Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Add scan_blocks_per_iteration and scan_interval_ms to ZcoinActivationParams. #1622

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[r2r] Add scan_blocks_per_iteration and scan_interval_ms to ZcoinActivationParams. #1622

merged 3 commits into from
Jan 20, 2023

Conversation

artemii235
Copy link
Member

@artemii235 artemii235 requested a review from yurii-khi January 20, 2023 09:37
yurii-khi
yurii-khi previously approved these changes Jan 20, 2023
View reviewed changes
Copy link

@yurii-khi yurii-khi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm reducing CPU usage by changing activation params allows app to work in background without being killed by iOs, thanks for your help @artemii235 !

@artemii235 artemii235 changed the title [wip] Add scan_blocks_per_iteration and scan_interval_ms to ZcoinActivationParams. [r2r] Add scan_blocks_per_iteration and scan_interval_ms to ZcoinActivationParams. Jan 20, 2023
shamardy
shamardy reviewed Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always! Just one question.

azure-pipelines.yml Outdated Show resolved Hide resolved
shamardy
shamardy approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sergeyboyko0791
sergeyboyko0791 suggested changes Jan 20, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! I have only one question

mm2src/coins/z_coin/z_rpc.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Jan 20, 2023
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@artemii235 artemii235 merged commit f32e01b into dev Jan 20, 2023
@artemii235 artemii235 deleted the zcoin-enable-cpu-consumption branch January 20, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@shamardy shamardy shamardy approved these changes

@yurii-khi yurii-khi yurii-khi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artemii235 @yurii-khi @shamardy @sergeyboyko0791