unicode support added to correct issue617 #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimiNewt
approved these changes
Jan 31, 2023
|
Thanks @KimiNewt for the approval. Only you can do the final merge.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the two line patch to handle issue #617. The changes allow for a unicode string to be handled by
lxml.objectify.fromstring()without it returningNone, as it does presently.This bug can be easily reproduced by running the
bpf_filterstringudp port 5353and then add a emoji to your device name (like an iPhone). This causes MDNS packets (i.e. port 5353) to contain an unicode string.The code change seems to cleanly fix this issue and doesn't affect existing xml packet strings.