A couple of fixes to the GL_QCOM_image_processing2 support #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) handle the extension requirements of GL_QCOM_image_processing2 correctly 2) add QCOM image processing decorations to ids only once.
1) handle the extension requirements of GL_QCOM_image_processing2 correctly 2) add QCOM image processing decorations to ids only once.
arcady-lunarg
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Sorry, I should have reviewed the original change more thoroughly, we really shouldn't be checking in expected results with "Validation failed" messages. However, it seems like you still have a "Bad" in your expected results, which is probably something you forgot to add to the appropriate switch statement in SPIRV/doc.cpp.
1) handle the extension requirements of GL_QCOM_image_processing2 correctly 2) add QCOM image processing decorations to ids only once.
arcady-lunarg
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correctly