Update SPIRV-Tools and SPIRV-Headers #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know anything about the new Validation failed messages? I checked one manually and its passing. |
This pulls in a recent validator change that checks which stages are allowed Output variables. Glslang's HLSL path generates Output variables for some cases at least. That is why there are new failures. The new success is the subgroup uniform control flow. |
|
Ah. Yes, validation is failing with --target-env vulkan1.2. I will make a note to clean those tests up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SPIRV-Tools (and its headers) to latest.
Fixes test expectations due to validation changes.