Add GL_EXT_shader_subgroup_extended_types support #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkslang
reviewed
Sep 18, 2019
|
|
||
| "\n"); | ||
| // Generate all flavors of subgroup ops. | ||
| static const char *subgroupOps[] = |
johnkslang
requested changes
Sep 18, 2019
| "bool", "bvec2", "bvec3", "bvec4", | ||
| }; | ||
|
|
||
| for (unsigned int i = 0; i < sizeof(subgroupOps)/sizeof(subgroupOps[0]); ++i) { |
There was a problem hiding this comment.
This needs to be size_t to satisfy some environments.
| char buf[bufSize]; | ||
|
|
||
| if (!logicalOp) { | ||
| for (unsigned int j = 0; j < sizeof(floatTypes)/sizeof(floatTypes[0]); ++j) { |
| commonBuiltins.append(buf); | ||
| } | ||
| if (profile != EEsProfile && version >= 400) { | ||
| for (unsigned int j = 0; j < sizeof(doubleTypes)/sizeof(doubleTypes[0]); ++j) { |
jeffbolznv
force-pushed
the
extended_types
branch
from
a46a09c to
c5b669e
Compare
|
Fixed the size_t stuff. |
johnkslang
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.