Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove texture coords from models that don't have a texture #493

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

stevk
Copy link
Contributor

@stevk stevk commented Jan 22, 2019

Only add texture cords to models that have a texture. This fix affects a couple of the models in the Material, Material_AlphaBlend, and Material_MetallicRoughness model groups. Before this fix models with texture cords but no texture have an error in the validator.

This wasn't a recent regression. These models have always had this issue, and I think the validator added this error check since the late time we validated all of the models.

@stevk stevk self-assigned this Jan 22, 2019
@stevk stevk requested review from kcoley and bghgary January 22, 2019 23:16
Source/ModelGroups/Material.cs Outdated Show resolved Hide resolved
@stevk stevk merged commit c2210b1 into KhronosGroup:master Feb 1, 2019
@stevk stevk deleted the textcoords branch February 1, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants