-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the KHR_materials_iridescence effect #2027
Adding the KHR_materials_iridescence effect #2027
Conversation
Update from Khronos
KHR_materials_transmission
KHR_materials_thickness
Upate to latest glTF
Update to latest version.
@sebavan this is defined in the specular extension and adopted by this extension (see KHR_materials_specular #Implementation). The issue is, that if we simply use Another approach would've been to use the grayscale representation of |
On the call today it was suggested we rename |
All good for me I changed it in Babylon and it should be up in the next couple hours :-) |
We can also make the changes in Gestaltor. |
However, did we think about the camel case rule for OpenGL. or OpenXR? |
@UX3D-nopper |
So the rule is like the one here: https://google.github.io/styleguide/jsguide.html#naming-camel-case-defined |
I have opened a pull request for the sample models (iridescenceIOR->iridescenceIor): KhronosGroup/glTF-Sample-Models#349 |
PR for gltf-transform: donmccurdy/glTF-Transform#570 |
Update Iridescence copyright & contributors
It would be helpful if the code block in the Extending Materials section included each of the Properties, to illustrate all their formatting, e.g.:
|
This was ratified by the Khronos Board on July 22, 2022. |
Replaces #1742