-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
layers: Fix debug label validation #5941
Conversation
CI Vulkan-ValidationLayers build queued with queue ID 10422. |
CI Vulkan-ValidationLayers build # 12255 running. |
CI Vulkan-ValidationLayers build queued with queue ID 10435. |
CI Vulkan-ValidationLayers build # 12256 running. |
CI Vulkan-ValidationLayers build # 12256 failed. |
This is 100% the |
My main concern was this 1 line here from the description.
Which makes it sounds like you can open a debug label region on 1 queue. Submit. Then end the debug label, then submit. And when talking to @MarkY-LunarG (The author of this extension) they said
|
This logic goes back because we were asked to support this across multiple QueueSubmits. Because of this, we really can only validate this on the GPU using something akin to GPU AV where we have a check for every |
CI Vulkan-ValidationLayers build queued with queue ID 11153. |
This VUID cannot be validated in vkCmdEndDebugUtilsLabelEXT So I'm adding it to the unimplementable_validation.h file. My plan is to help fix/clear up the specification. Meanwhile fixing up this false positive and adding positive testing to prevent a regression. closes #5671
CI Vulkan-ValidationLayers build queued with queue ID 11154. |
CI Vulkan-ValidationLayers build # 12277 running. |
CI Vulkan-ValidationLayers build # 12277 passed. |
This VUID cannot be validated in vkCmdEndDebugUtilsLabelEXT
So I'm adding it to the unimplementable_validation.h file.
My plan is to help fix/clear up the specification.
Meanwhile fixing up this false positive and adding positive
testing to prevent a regression.
closes #5671