Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding a buffer with VK_BUFFER_USAGE_VERTEX_BUFFER_BIT as a storage buffer using push descriptors doesn't produce validation errors #413

Closed
zeux opened this issue Oct 20, 2018 · 3 comments
Closed

Binding a buffer with VK_BUFFER_USAGE_VERTEX_BUFFER_BIT as a storage buffer using push descriptors doesn't produce validation errors #413

zeux opened this issue Oct 20, 2018 · 3 comments
Assignees
@jzulauf-lunarg
Labels
Incomplete Missing Validation VUs to be added
Milestone
sdk-1.1.97.0

Comments

@zeux
Copy link

zeux commented Oct 20, 2018

My code was creating a buffer with VkBufferCreateInfo::usage = VK_BUFFER_USAGE_VERTEX_BUFFER_BIT and then using push descriptors to set it as follows:

	VkWriteDescriptorSet descriptors[1] = {};
	descriptors[0].sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
	descriptors[0].dstBinding = 0;
	descriptors[0].descriptorCount = 1;
	descriptors[0].descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER;
	descriptors[0].pBufferInfo = &vbInfo;

	vkCmdPushDescriptorSetKHR(commandBuffer, VK_PIPELINE_BIND_POINT_GRAPHICS, triangleLayout, 0, ARRAYSIZE(descriptors), descriptors);

Validation layers produced no errors. This looks incorrect to me - VK_DESCRIPTOR_TYPE_STORAGE_BUFFER should require that the buffer is created with VK_BUFFER_USAGE_STORAGE_BUFFER_BIT.
@jzulauf-lunarg jzulauf-lunarg added the Incomplete Missing Validation VUs to be added label Oct 22, 2018
@jzulauf-lunarg
Copy link
Contributor

jzulauf-lunarg commented Oct 22, 2018 •
edited
Loading

PushDescriptor validation is highly incomplete. On my list right behind template descriptor update validation.

@jzulauf-lunarg jzulauf-lunarg mentioned this issue Nov 8, 2018
Merged
@jzulauf-lunarg
Copy link
Contributor

PR addressing this issue under review #460

@jzulauf-lunarg
Copy link
Contributor

merged

@shannon-lunarg shannon-lunarg added this to the sdk-1.1.temp.0 milestone Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzulauf-lunarg jzulauf-lunarg

Labels
Incomplete Missing Validation VUs to be added
Projects
None yet
Milestone
sdk-1.1.97.0
Development

No branches or pull requests
4 participants
@zeux @mark-lunarg @shannon-lunarg @jzulauf-lunarg