Experiments/chipwhisperer converter #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required the chipwhisperer import to function
Siebje
force-pushed
the
experiments/chipwhisperer_converter
branch
from
5d771be to
018a18c
Compare
StefanD986
reviewed
May 5, 2022
There was a problem hiding this comment.
To me the chip whisperer conversion is more as an application of the library, rather than a part of the library itself. Thats why I would suggest to move this to an examples/ directory in the root.
Consequence would of course be that its not installed as part of pip install trsfile (which is maybe the reason why it was added here?)
A compromise would be to move it to trsfile/examples, although I still do not really like it, because making it part of the library makes a bit of a strong statement of we support this, whereas if we make it separate from the library its more here is, do whatever you want with it but don't complain if we break it
TomHogervorst
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a generic converter for ChipWhisperer traces to TRSv2
This has been tested manually on the ChipWhisperer examples repo (https://github.com/newaetech/chipwhisperer-examples)
Thanks to @colinoflynn for providing open source access to his code.