Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable interaction during expand animation #248

Merged

Conversation

tushar-nallan
Copy link
Contributor

No description provided.

@tushar-nallan tushar-nallan force-pushed the disable-interaction-in-animation branch from 5bd5bd1 to 17781e0 Compare January 18, 2018 16:18
@xiphirx
Copy link
Collaborator

xiphirx commented Jan 19, 2018

This needs to be split into two PRs. One to upgrade the Android Gradle plugin + Gradle itself and the other to disable interaction during the expand animation.

@tushar-nallan tushar-nallan force-pushed the disable-interaction-in-animation branch from 17781e0 to 730cb24 Compare January 19, 2018 23:18
@tushar-nallan
Copy link
Contributor Author

Done, I've created a new PR with the gradle changes

@tushar-nallan tushar-nallan changed the title Update gradle and disable interaction during expand animation Disable interaction during expand animation Jan 23, 2018
@tushar-nallan
Copy link
Contributor Author

@xiphirx Sorry for pushing, we have a release coming up and this was one of the things we wanted to put in the release.

@xiphirx xiphirx merged commit 0c7cb95 into KeepSafe:master Jan 24, 2018
@tushar-nallan tushar-nallan deleted the disable-interaction-in-animation branch January 24, 2018 09:19
ganny26 pushed a commit to wa2do/TapTargetView that referenced this pull request Aug 10, 2018
ganny26 added a commit to wa2do/TapTargetView that referenced this pull request Aug 10, 2018
* Add startWith and startAt to TapTargetSequence (KeepSafe#228)

Previously it was cumbersome to restore state in a TapTargetSequence
after rotation due to the fact that you needed to manually modify the
list of targets you pass in to get back to your desired target. Now the
class supports starting from a specified target id or position in the
queue, allowing callers to keep a static list of targets for their
sequence.

* Added Support for React Native Projects (KeepSafe#230)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Add notion of isDismissing and gate onReady() callbacks on it (KeepSafe#243)

* Add notion of isDismissing and gate onReady() callbacks on it

There was a race condition I came across where a view could be animating out at the same time as the animation for dismissing the tap target. If the view animated out before the taptarget, it would trigger a layout again, and potentially redisplay the taptarget again. This gates onReady callbacks against the notion of "isDismissing". Tested locally in my project and confirmed this resolves the issue.

* Return early (and earlier!)

* Fix NPE when dismiss is called immediately (KeepSafe#244)

Small "race" condition that shouldn't crash. Fixes KeepSafe#240

* 1.11.0

* Fix "sometimes" typo (KeepSafe#246)

* Update Gradle version (KeepSafe#253)

* Disable interaction during expand animation (KeepSafe#248)

* Fix build (KeepSafe#256)

* Update to latest support library + SDK version (KeepSafe#257)

Was pretty outdated previously.

* Use api configuration for public dependencies. (KeepSafe#258)

Some support annotations and the v7 support Toolbar are both part of the
public api, so they need to be specified as `api` in order for them to
transitively picked up by downstream dependants.

* Update build tools to most recent ones (KeepSafe#261)

* update build tools to most recent ones

* revert to last stable version and use gradle 4.5

* Use central build variables (KeepSafe#264)

* in module "taptargetview" buildToolsVersion was missing und request an install of 26.0.2
* variable SupportLibraryVersion was just in one module

* Handle dismiss before show

* Replacement of "compile" with "implementation" (KeepSafe#291)

As "compile" is going to be deprecated end-2018, this PR replaces with "implementation" that is the new usage.

* Fix NPE from dismissal before determining center (KeepSafe#298)

Fixes KeepSafe#279

* Fix not being able to cancel on last target (KeepSafe#299)

Simplifies an early return + properly unsets currentView. Fixes KeepSafe#294

* Fix decor related issues (KeepSafe#300)

This fixes issues relating to transparent nav bars, status bars and
multi window mode. The library will now detect when the window it is
attached to has a transparent system bar and properly adjust its clip
bounds. Fixes KeepSafe#233

* Release 1.12.0

* Updated readme to reflect latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants