Fix Latte 2.5 compatibility #164
Conversation
…TranslateMacros since it's ancestor uses Tracy\Strict
|
@jankonas Can you update your PR please? |
|
@foxycode I will after Kdyby/Monolog#35 is merged and new version is tagged. |
|
@foxycode FYI since the mentioned PR only allows Nette 3.0 packages I requested tagging new kdyby/monolog version without it (Kdyby/Monolog#38) so I hope it will be soon :-) |
jankonas
force-pushed
the
latte-compatibility
branch
from
2675644 to
acee849
Compare
jankonas
changed the title
|
@enumag I think it's ready to merge (and maybe tag new version? 😉). |
| @@ -46,7 +46,6 @@ public function extractFile($file, MessageCatalogue $catalogue) | |||
| { | |||
| $buffer = NULL; | |||
| $parser = new Parser(); | |||
| $parser->shortNoEscape = TRUE; | |||
There was a problem hiding this comment.
Is it ok to remove this for Latte 2.4?
There was a problem hiding this comment.
For 2.4 absolutely, it was already deprecated then. For lower versions I'm not sure, but nobody objected when I asked for review here and on Slack.
There was a problem hiding this comment.
composer.json here requieres "latte/latte": "^2.4.6@dev", anyway so we don't need to handle the lower versions
Resolves #159, closes #160, closes #161, closes #162, closes #163
BC breaks! 😱
Maybe breaks on lower latte versions? (See below)no one reported any problemMinimal Latte version compatibility?
I removed one line from
Kdyby\Translation\Extractors\LatteExtractorthat depended on function deprecated in Latte 2.4 and removed in Latte 2.5. But I have no idea whether this breaks compatibility with lower Latte versions (in which case the constraint in composer.json should be updated) or not. Is there someone with better knowledge of this package who knows?